----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38635/#review100171 -----------------------------------------------------------
src/linux/systemd.cpp (line 161) <https://reviews.apache.org/r/38635/#comment157334> Why not use os::write? src/slave/containerizer/linux_launcher.hpp (line 28) <https://reviews.apache.org/r/38635/#comment157332> What do you mean by detect these? src/slave/containerizer/linux_launcher.cpp (line 117) <https://reviews.apache.org/r/38635/#comment157333> How about we do what libprocess does where we initialize on each system:: call, and you don't have to initialize explicitly src/slave/containerizer/linux_launcher.cpp (line 128) <https://reviews.apache.org/r/38635/#comment157335> This seems pretty systemd specific, why not move this into the systemd.cpp? src/slave/flags.cpp (line 313) <https://reviews.apache.org/r/38635/#comment157331> systemd system run time - Timothy Chen On Sept. 23, 2015, 1:48 a.m., Joris Van Remoortere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38635/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2015, 1:48 a.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Niklas > Nielsen, Thomas Rampelberg, and Timothy Chen. > > > Bugs: MESOS-3425 > https://issues.apache.org/jira/browse/MESOS-3425 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/linux/systemd.hpp PRE-CREATION > src/linux/systemd.cpp PRE-CREATION > src/slave/containerizer/linux_launcher.hpp > f6112c98ffcc46ebcaf5581e821d5481d2f6b494 > src/slave/containerizer/linux_launcher.cpp > fd0ffcf838a745ccd458d57821d358eceb85be26 > src/slave/flags.hpp e31a4183170c3442ac4a15365c229391e7e91480 > src/slave/flags.cpp add4196dfd06c0f602ff5ebd39960dc05c4cd11f > > Diff: https://reviews.apache.org/r/38635/diff/ > > > Testing > ------- > > > Thanks, > > Joris Van Remoortere > >
