> On Sept. 25, 2015, 6:24 a.m., Alex Clemmer wrote: > > Hey, it doesn't look like `src/tests/digest_tests.cpp` is being added to > > the `CMakeLists.txt` file in `3rdparty/libprocess/src/tests`. Is that > > correct? If not, could we please add it there as well? > > > > (I have forgotten to add a list of header files as dependencies, so you > > can't add that quite yet.) > > Alex Clemmer wrote: > Ah, after testing, we won't have to include the header lists at all, so > you don't have to add that to a list. It turns out that if you pass the > `include/` folder into the `include_directory` function, it automatically > will monitor those files for changes. :) So we're good. > > But, unless I'm mistaken, we'd still have to add that test to the > `CMakeLists.txt`. Let me know if my thinking is wrong here.
Added. Didnt know this extra step existed :) - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100539 ----------------------------------------------------------- On Sept. 25, 2015, 4:45 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2015, 4:45 p.m.) > > > Review request for mesos, Gilbert Song and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added SHA256 implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 064310c61d8a0c5c5a87f305f1f62149dd3a6699 > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/digest.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
