> On Sept. 28, 2015, 7:17 p.m., Jiang Yan Xu wrote: > > High-level comments: > > > > - This implementation relies on USE_SSL_SOCKET which is tied to > > `--enable_ssl`. Conceptually the two should be decoupled. Ian Downes has an > > implementation which uses the system commands that are widely distributed > > on *nix boxes: https://reviews.apache.org/r/34138/. Can such an > > implemenation be used as a fallback at least? > > - Can the implentation be put in a cpp file and leave only public (the > > recommended way of using this utility) methods in the header (e.g. > > `process::verify(...)` and `process::digest()`)?
Thanks for the suggestion and history. - digest.hpp's process::digest and process::verify has default implementations (when USE_SSL_SOCKET is not available). So thats the fallback for now. - Since this implementation is dependent on using traits/templates, the implementation is in hpp file - I can work on adding Ian's implementation in this patch or let Ian add it as an extension to this patch. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38747/#review100850 ----------------------------------------------------------- On Sept. 28, 2015, 10:14 p.m., Jojy Varghese wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38747/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2015, 10:14 p.m.) > > > Review request for mesos, Gilbert Song and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Added SHA256, SHA512 implementation. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c764717d447da39f78a9c74a756e611b63a814e1 > 3rdparty/libprocess/include/Makefile.am > fcc62e99b92b9d2e7ab344e561a06dd6de1fef7e > 3rdparty/libprocess/include/process/digest.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/CMakeLists.txt > a14b5b8fe22d3e75bef3c716ae7865ddaf132927 > 3rdparty/libprocess/src/tests/digest_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38747/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jojy Varghese > >
