> On Oct. 5, 2015, 6:48 p.m., Marco Massenzio wrote: > > src/version/version.cpp, lines 81-82 > > <https://reviews.apache.org/r/37024/diff/6/?file=1090173#file1090173line81> > > > > Minor nit: s/mesos/Apache Mesos and I think you can drop the "This > > endpoint" - "Shows the current version and build information for Apache > > Mesos" > > > > or something like that...
Also, can you please make sure that in the commit comment we have a full description of the endpoint's returned result (I also think that the description above is no longer current?). - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37024/#review101508 ----------------------------------------------------------- On Oct. 5, 2015, 8 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37024/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2015, 8 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1841 > https://issues.apache.org/jira/browse/MESOS-1841 > > > Repository: mesos > > > Description > ------- > > Add an endpoint that exposes component version. > > > Diffs > ----- > > src/Makefile.am e69892736b0edc8c264eaccd52a04d44d01f53ba > src/exec/exec.cpp 7b51baaa8c08d248918974a3a22b6217e388bcb1 > src/local/main.cpp 18b2f0187637cd425d55c220f73faac5a1218f0f > src/master/main.cpp bafc605d6c20bd264b932e44ee80373a3f692734 > src/sched/sched.cpp 571e00d303009a940f17c8ed4582749a718e846d > src/slave/main.cpp 364dc7fc7ab2e3cef01aea7267dafa014b60e2b9 > src/version/version.hpp PRE-CREATION > src/version/version.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/37024/diff/ > > > Testing > ------- > > Manual test result: > > ``` > $ curl http://localhost:5050/version 2>/dev/null|jq . > > { > "version": "0.24.0", > "build_user": "haosdent", > "build_time": 1439702338, > "build_date": "2015-08-16 13:18:58" > } > ``` > > > Thanks, > > haosdent huang > >
