----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39087/#review101901 -----------------------------------------------------------
Ship it! Ship It! - Jan Schlicht On Oct. 7, 2015, 4:54 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39087/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2015, 4:54 p.m.) > > > Review request for mesos and Jan Schlicht. > > > Bugs: MESOS-3268 > https://issues.apache.org/jira/browse/MESOS-3268 > > > Repository: mesos > > > Description > ------- > > Added support for non-ascii chars to apply-review.sh. > > > Diffs > ----- > > support/jsonurl.py f6b54d8f8b0402f703d5758704a3f783dd9b3ef9 > > Diff: https://reviews.apache.org/r/39087/diff/ > > > Testing > ------- > > Tested this on OS X. > > Without this patch: > > ``` > $ ./support/apply-review.sh -n -r 39086 > 2015-10-07 16:41:06 URL:https://reviews.apache.org/r/39086/diff/raw/ > [5430/5430] -> "39086.patch" [1] > Traceback (most recent call last): > File "./support/jsonurl.py", line 25, in <module> > print data > UnicodeEncodeError: 'ascii' codec can't encode character u'\xf3' in position > 4: ordinal not in range(128) > Successfully applied: Fixed typos in comments and docs. > > Fixed typos in comments and docs. > > > Review: https://reviews.apache.org/r/39086 > fatal: empty ident name (for <gas...@mesosphere.com>) not allowed > Failed to commit patch > $ > ``` > > With this patch: > > ``` > $ ./support/apply-review.sh -n -r 39086 > 2015-10-07 16:42:09 URL:https://reviews.apache.org/r/39086/diff/raw/ > [5430/5430] -> "39086.patch" [1] > Successfully applied: Fixed typos in comments and docs. > > Fixed typos in comments and docs. > > > Review: https://reviews.apache.org/r/39086 > Checking 2 files using filter > --filter=-,+build/class,+build/deprecated,+build/endif_comment,+readability/todo,+readability/namespace,+runtime/vlog,+whitespace/blank_line,+whitespace/comma,+whitespace/end_of_line,+whitespace/ending_newline,+whitespace/forcolon,+whitespace/indent,+whitespace/line_length,+whitespace/operators,+whitespace/semicolon,+whitespace/tab,+whitespace/todo > Total errors found: 0 > [fix_3268 d51d32a] Fixed typos in comments and docs. > Author: Gastón Kleiman <gas...@mesosphere.com> > 6 files changed, 12 insertions(+), 12 deletions(-) > $ > ``` > > > Thanks, > > Gastón Kleiman > >
