----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39152/#review102116 -----------------------------------------------------------
Ship it! Thanks! I'll fix the indent and commit this. Also, you did more than just run `make check`, you modified MesosContainerizerIsolatorPreparationTest.ExecutorEnvironmentVariable to test your env-variable setting. Call that out in the "Testing Done" section. src/tests/containerizer/mesos_containerizer_tests.cpp (lines 334 - 336) <https://reviews.apache.org/r/39152/#comment159646> We only indent 2 spaces after a trailing '='. Try a `grep -rn -B1 "^[^a-zA-Z0-9]*\".*\"$" src/ |grep -A2 "=$"` and you'll see. - Adam B On Oct. 9, 2015, 1:34 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39152/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2015, 1:34 p.m.) > > > Review request for mesos, Adam B and Kapil Arya. > > > Bugs: MESOS-3553 > https://issues.apache.org/jira/browse/MESOS-3553 > > > Repository: mesos > > > Description > ------- > > If DNS is not available on the agent node and a task is launched which > explicitly specifies the executor's environment, LIBPROCESS_IP will not be > passed through and the default hostname lookup after spawning the executor > process will throw an error. This patch alters the agent to always pass > LIBPROCESS_IP, even when the executor environment is specified. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > 25c87e9f948b7efe8b9a853c403bee69982d6c4c > src/tests/containerizer/mesos_containerizer_tests.cpp > 5bc7d408bda0c249e1b66747d8bd87e688362e6c > > Diff: https://reviews.apache.org/r/39152/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
