> On Oct. 10, 2015, 12:10 p.m., Alex Clemmer wrote: > > src/Makefile.am, line 463 > > <https://reviews.apache.org/r/38950/diff/2/?file=1091642#file1091642line463> > > > > (I hesistate to comment this time, but...) could we add this to the > > `CMakeLists.txt` file in `src/`? (It looks to be a `.cpp` file, and we > > appear to have the other authentication `.cpp` files, so I think this one > > is a legitimate line we should add :) )
Not sure if I added all the files I needed to, any reason why we cannot use `FILE(GLOB_RECURSE …)` - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38950/#review102160 ----------------------------------------------------------- On Oct. 12, 2015, 11:30 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38950/ > ----------------------------------------------------------- > > (Updated Oct. 12, 2015, 11:30 a.m.) > > > Review request for mesos, Adam B, Bernd Mathiske, and Till Toenshoff. > > > Bugs: MESOS-3232 > https://issues.apache.org/jira/browse/MESOS-3232 > > > Repository: mesos > > > Description > ------- > > Adds support for modularization of HTTP Authenticators. > > It includes an example of how to do it with the Basic HTTP Authenticator. > > > Diffs > ----- > > include/mesos/authentication/http/basic_authenticator_factory.hpp > PRE-CREATION > include/mesos/module/http_authenticator.hpp PRE-CREATION > src/CMakeLists.txt 828dbb690841c561816811dfbb044aa3afead89d > src/Makefile.am d855cb83277c3e0e2ee3feacaf6ad0962223ef6e > src/authentication/http/basic_authenticator_factory.cpp PRE-CREATION > src/examples/test_http_authenticator_module.cpp PRE-CREATION > src/master/constants.hpp 51d477444c4d1a2c9dd2f32164ebffbb1fd5c8c2 > src/master/constants.cpp 2b66b27783f18930010ee912e9977ea1647eba09 > src/module/manager.cpp f9a0643a70bc9de1484599629041650493842c69 > src/tests/http_authentication_tests.cpp PRE-CREATION > src/tests/module.hpp 0820978441aede18dae6d1701433bff705b8c3c2 > src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f > > Diff: https://reviews.apache.org/r/38950/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
