----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review102774 -----------------------------------------------------------
src/tests/fault_tolerance_tests.cpp (line 721) <https://reviews.apache.org/r/39320/#comment160536> I don't think hardcoding specific timeouts here is optimal ... there's nothing here that prevents this from not failing on slow/high load machines. Better would be to e.g. `wait` for some observable side effect before continuing; at least add a `TODO` (or better ticket) for that. - Benjamin Bannier On Oct. 14, 2015, 4:29 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39320/ > ----------------------------------------------------------- > > (Updated Oct. 14, 2015, 4:29 p.m.) > > > Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3732 > https://issues.apache.org/jira/browse/MESOS-3732 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > c97bc4691f9bac4a8677e6d2247be96ee9674b57 > > Diff: https://reviews.apache.org/r/39320/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
