> On Oct. 15, 2015, 11:37 a.m., Benjamin Bannier wrote: > > src/tests/fault_tolerance_tests.cpp, line 721 > > <https://reviews.apache.org/r/39320/diff/1/?file=1098367#file1098367line721> > > > > I don't think hardcoding specific timeouts here is optimal ... there's > > nothing here that prevents this from not failing on slow/high load > > machines. Better would be to e.g. `wait` for some observable side effect > > before continuing; at least add a `TODO` (or better ticket) for that.
The test won't fail on slow machines, it will just take longer. However, I agree we a nicer solution is to intercept the allocation event and `advance()` the clock. As I have mentioned in the ticket (https://issues.apache.org/jira/browse/MESOS-3732), a better fix can be done by a new contributor. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39320/#review102774 ----------------------------------------------------------- On Oct. 16, 2015, 11:44 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39320/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 11:44 a.m.) > > > Review request for mesos, Benjamin Bannier, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3732 > https://issues.apache.org/jira/browse/MESOS-3732 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/tests/fault_tolerance_tests.cpp > c97bc4691f9bac4a8677e6d2247be96ee9674b57 > > Diff: https://reviews.apache.org/r/39320/diff/ > > > Testing > ------- > > make check > > The run time for the `FaultToleranceTest.FrameworkReregister` test has > reduced from more than `1s` to less than `100ms`. > Before: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (1018 ms) > ``` > After: > ``` > [ RUN ] FaultToleranceTest.FrameworkReregister > [ OK ] FaultToleranceTest.FrameworkReregister (49 ms) > ``` > > > Thanks, > > Alexander Rukletsov > >
