----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39381/#review102979 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Oct. 16, 2015, 12:50 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39381/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 12:50 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-3610 > https://issues.apache.org/jira/browse/MESOS-3610 > > > Repository: mesos > > > Description > ------- > > CMake: Added protobuf and `slave/flags.cpp` to Windows builds. > > > Diffs > ----- > > src/CMakeLists.txt 35e5cdc81677b26971920140404cd16d268a379b > > Diff: https://reviews.apache.org/r/39381/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 > on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
