> On Oct. 16, 2015, 8:23 p.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [39383] > > > > Failed command: ./support/apply-review.sh -n -r 39383 > > > > Error: > > 2015-10-16 20:19:45 URL:https://reviews.apache.org/r/39383/diff/raw/ > > [6017/6017] -> "39383.patch" [1] > > error: patch failed: > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am:54 > > error: 3rdparty/libprocess/3rdparty/stout/include/Makefile.am: patch does > > not apply > > error: patch failed: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp:78 > > error: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp: patch does > > not apply > > Failed to apply patch
This is going to fail because it actually does depend on 39382. But, I took 39382 out of the dependency chain though because I wanted to make it explicit that this review should not be slurped up when Joris applies them. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review102981 ----------------------------------------------------------- On Oct. 16, 2015, 8:03 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39383/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2015, 8:03 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 9e9c3119ad18f4cbc70c70095c71dc4fd19553df > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 5141c1369af60afd6cd5c70c6295d575ea960a83 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39383/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 > on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
