----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39383/#review103805 -----------------------------------------------------------
Confirmed that `mkdir` logic is essentially unchanged. 3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp (line 19) <https://reviews.apache.org/r/39383/#comment161896> We usually write constants like this: ``` const std::string DIRECTORY_SEPARATOR = "/"; ``` - Joseph Wu On Oct. 22, 2015, 10:40 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39383/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 10:40 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Moved `os::mkdir` to its own file, `stout/os/mkdir`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > ba2836a72ceee948cb43364e80ada9f132f33d04 > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 7f70c9ea7d57634b5bfd40523ba37561ec92a09a > 3rdparty/libprocess/3rdparty/stout/include/stout/os/constants.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/mkdir.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39383/diff/ > > > Testing > ------- > > CMake `make check` on Ubuntu 15, OS X 10.10, and ran `check` target in VS2015 > on Windows 10. > > Autotools `make check` on Ubuntu 15. > > > Thanks, > > Alex Clemmer > >
