> On Oct. 22, 2015, 8:13 p.m., Kapil Arya wrote: > > src/common/http.cpp, lines 165-180 > > <https://reviews.apache.org/r/39531/diff/5/?file=1103491#file1103491line165> > > > > Dumb question -- could we have used `JSON::Protobuf()` instead? > > Connor Doyle wrote: > Hey Kapil, I'll try it out.
Good catch, updated to use JSON::Protobuf() instead. - Connor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103650 ----------------------------------------------------------- On Oct. 22, 2015, 11:22 p.m., Connor Doyle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39531/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 11:22 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-3788 > https://issues.apache.org/jira/browse/MESOS-3788 > > > Repository: mesos > > > Description > ------- > > In Mesos 0.25.0, a new message called NetworkInfo was introduced. This > message allows framework authors to communicate with network isolation > modules via a first-class message type to request IP addresses and network > group isolation policies. > > Unfortunately, the structure is somewhat confusing to both framework authors > and module implementors. > > 1) It's unclear how IP addresses map to virtual interfaces inside the > container. > 2) It's difficult for application developers to understand the final policy > when multiple IP addresses can be assigned with differing isolation policies. > > NOTE: the slave should also be updated in order to set the new IpAddress > message in ContainerStatus in case network isolation modules are not > installed. > > > Diffs > ----- > > docs/networking-for-mesos-managed-containers.md 33568a8 > include/mesos/mesos.proto 9400434 > include/mesos/v1/mesos.proto 8131778 > src/common/http.cpp f56d8a1 > src/docker/executor.cpp 1e49013 > src/examples/test_hook_module.cpp 43d6cb9 > src/slave/slave.cpp e9f2d1b > src/tests/common/http_tests.cpp c2e7704 > src/tests/hook_tests.cpp 5a5d019 > > Diff: https://reviews.apache.org/r/39531/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Connor Doyle > >
