----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39531/#review103690 -----------------------------------------------------------
Wow! Awesome documentation work! A few suggestions below. Mainly: We haven't planned 0.25.1, so let's bump to 0.26.0. The description is specific to isolators doing the heavy lifting, whereas we could be doing some of the IP assignment in the master (eventually). Other than that; looks good! docs/networking-for-mesos-managed-containers.md (line 140) <https://reviews.apache.org/r/39531/#comment161753> Let's change this to 0.26.0 include/mesos/mesos.proto (line 1389) <https://reviews.apache.org/r/39531/#comment161754> 'the actual assigned IP adress' reads a bit odd. How about something like: "A user can request an automatically assigned IP (for example, through an IPAM service) or a specific IP" No biggie; if you don't like the suggestion, feel free to drop include/mesos/mesos.proto (lines 1392 - 1394) <https://reviews.apache.org/r/39531/#comment161755> We could, theoretically, have this be done from other places than the isolator. Wonder if we can abstract this out a bit include/mesos/mesos.proto (line 1425) <https://reviews.apache.org/r/39531/#comment161758> s/0.25.1/0.26.0/ include/mesos/v1/mesos.proto (line 1343) <https://reviews.apache.org/r/39531/#comment161756> As a non-native speaker; what's the consistency around capitalizing framework :) include/mesos/v1/mesos.proto (line 1350) <https://reviews.apache.org/r/39531/#comment161757> Agent and Master? src/common/http.cpp (lines 165 - 166) <https://reviews.apache.org/r/39531/#comment161759> Can we inline JSON::Protobuf() instead? src/examples/test_hook_module.cpp (line 261) <https://reviews.apache.org/r/39531/#comment161760> 0.27.0? - Niklas Nielsen On Oct. 22, 2015, 4:30 p.m., Connor Doyle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39531/ > ----------------------------------------------------------- > > (Updated Oct. 22, 2015, 4:30 p.m.) > > > Review request for mesos, Benjamin Hindman and Kapil Arya. > > > Bugs: MESOS-3788 > https://issues.apache.org/jira/browse/MESOS-3788 > > > Repository: mesos > > > Description > ------- > > In Mesos 0.25.0, a new message called NetworkInfo was introduced. This > message allows framework authors to communicate with network isolation > modules via a first-class message type to request IP addresses and network > group isolation policies. > > Unfortunately, the structure is somewhat confusing to both framework authors > and module implementors. > > 1) It's unclear how IP addresses map to virtual interfaces inside the > container. > 2) It's difficult for application developers to understand the final policy > when multiple IP addresses can be assigned with differing isolation policies. > > > Diffs > ----- > > docs/networking-for-mesos-managed-containers.md 33568a8 > include/mesos/mesos.proto 9400434 > include/mesos/v1/mesos.proto 8131778 > src/common/http.cpp f56d8a1 > src/docker/executor.cpp 1e49013 > src/examples/test_hook_module.cpp 43d6cb9 > src/slave/slave.cpp e9f2d1b > src/tests/common/http_tests.cpp c2e7704 > src/tests/hook_tests.cpp 5a5d019 > > Diff: https://reviews.apache.org/r/39531/diff/ > > > Testing > ------- > > make && make check > > > Thanks, > > Connor Doyle > >
