----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103731 -----------------------------------------------------------
Ship it! This looks great - a really few minor nits, but then it's good to go! support/apply-reviews.py (lines 47 - 48) <https://reviews.apache.org/r/39410/#comment161807> s/cerror/error However, I think it'd read better as ``` # Trailing slash required by ReviewBoard's REST API ``` support/apply-reviews.py (line 49) <https://reviews.apache.org/r/39410/#comment161808> ``` if 'review_id' in options: ``` is more pythonic (also below: `elif 'github' in options`) support/apply-reviews.py (line 262) <https://reviews.apache.org/r/39410/#comment161813> you don't need the trailing \ also, please indent the second row, keeping the opening quotes aligned: ``` description='foo bar baz ' 'jump the fox') ``` support/apply-reviews.py (lines 287 - 290) <https://reviews.apache.org/r/39410/#comment161814> does this work? (I really am curious, I didn't know about the 'mutually exclusive' option!) in other words, don't you get an exception by trying to access **both** `args.github` AND `args.review_id` (because one of the two is missing)? - Marco Massenzio On Oct. 23, 2015, 6:18 a.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39410/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 6:18 a.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > Added support for github to apply-reviews.py. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/39410/diff/ > > > Testing > ------- > > Tested with python 2.7 > > > Thanks, > > Artem Harutyunyan > >
