> On Oct. 23, 2015, 12:18 a.m., Marco Massenzio wrote: > > support/apply-reviews.py, lines 287-290 > > <https://reviews.apache.org/r/39410/diff/4-6/?file=1101498#file1101498line287> > > > > does this work? (I really am curious, I didn't know about the 'mutually > > exclusive' option!) > > > > in other words, don't you get an exception by trying to access **both** > > `args.github` AND `args.review_id` (because one of the two is missing)?
It does :-). `args` sets the value of the missing option to `None`. - Artem ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39410/#review103731 ----------------------------------------------------------- On Oct. 23, 2015, 4:13 p.m., Artem Harutyunyan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39410/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2015, 4:13 p.m.) > > > Review request for mesos, Adam B, Joris Van Remoortere, Joseph Wu, Marco > Massenzio, and Vinod Kone. > > > Bugs: MESOS-3468 > https://issues.apache.org/jira/browse/MESOS-3468 > > > Repository: mesos > > > Description > ------- > > Added support for github to apply-reviews.py. > > > Diffs > ----- > > support/apply-reviews.py PRE-CREATION > > Diff: https://reviews.apache.org/r/39410/diff/ > > > Testing > ------- > > Tested with python 2.7 > > > Thanks, > > Artem Harutyunyan > >
