----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review104265 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 902) <https://reviews.apache.org/r/39400/#comment162534> Alex, just want to get more for why do we need to add '' for role? I know that role is user supplied, but does role will contain whitespace? If not, I think that there is no need to add '' for role output, comments? Thanks! - Guangya Liu On 十月 27, 2015, 7:17 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39400/ > ----------------------------------------------------------- > > (Updated 十月 27, 2015, 7:17 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39400/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >