> On Oct. 28, 2015, 8:54 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 903 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line903> > > > > Alex, just want to get more for why do we need to add '' for role? I > > know that role is user supplied, but does role will contain whitespace? If > > not, I think that there is no need to add '' for role output, comments? > > Thanks! > > Alexander Rukletsov wrote: > If I read > [this](https://github.com/apache/mesos/blob/master/src/master/master.cpp#L561) > correctly, nothing prevents a role from having spaces in its name.
Thanks Alex, yes, the role can include whitespace. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review104265 ----------------------------------------------------------- On Oct. 27, 2015, 7:17 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39400/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2015, 7:17 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van > Remoortere. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39400/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
