----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39771/#review104994 -----------------------------------------------------------
3rdparty/libprocess/src/subprocess.cpp (lines 179 - 180) <https://reviews.apache.org/r/39771/#comment163353> Technically we should not be appending strings like this since malloc is not async-signal-safe. But since you're not introducing the issue, it's alright. (1) Typically we would print like this: "Failed to os::execvpe on path '<path>': <reason>". (2) Mind fixing the indent on your second line? - Ben Mahler On Oct. 29, 2015, 9 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39771/ > ----------------------------------------------------------- > > (Updated Oct. 29, 2015, 9 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-3608 > https://issues.apache.org/jira/browse/MESOS-3608 > > > Repository: mesos > > > Description > ------- > > Show the failing path when execvpe(2) fails. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > 459825c188d56d25f6e2832e5a170d806e257d6b > > Diff: https://reviews.apache.org/r/39771/diff/ > > > Testing > ------- > > make check and manual testing. > > > Thanks, > > James Peach > >
