----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39878/#review105024 -----------------------------------------------------------
Ship it! src/master/master.cpp (line 6025) <https://reviews.apache.org/r/39878/#comment163391> Can we pull this comment and the one at 6031 up into a higher level comment above the Option? Instead of what we currently say on top of the Option which is pretty redundant with what the code expresses. ``` // Slave-generated updates will contain a 'latest_state'. Option<TaskState> latestState; if (update.has_latest_state()) { latestState = update.latest_state(); } bool terminated; if (latestState.isSome()) { ... } else { ... } ``` - Ben Mahler On Nov. 2, 2015, 9:49 p.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39878/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2015, 9:49 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > ------- > > The only functional change here is that updateTask() doesn't check for uuid > being set to empty string. > > > Diffs > ----- > > src/master/master.cpp 2bc5a97a5b50c8a8a9902c47b2e9e3b5216d97ea > > Diff: https://reviews.apache.org/r/39878/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
