----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review105062 -----------------------------------------------------------
src/master/quota_handler.cpp (line 151) <https://reviews.apache.org/r/38110/#comment163441> So for this TODO, in future, we want to count dynamically reserved resources in ```roleTotal```, right? But in the code below, I see the dynamically reserved resources have already been counted in ```availableOnAgent```, so if we count it here as well, will it be double counted? src/master/quota_handler.cpp (line 161) <https://reviews.apache.org/r/38110/#comment163436> Do we want to check if ```missingResources``` is empty first? Maybe the quota is already satisfied at this point. src/master/quota_handler.cpp (line 164) <https://reviews.apache.org/r/38110/#comment163430> Do we want to filter out the slave which is not active (slave->active == false)? - Qian Zhang On Nov. 3, 2015, 11:46 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38110/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2015, 11:46 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Michael Park. > > > Bugs: MESOS-3074 > https://issues.apache.org/jira/browse/MESOS-3074 > > > Repository: mesos > > > Description > ------- > > Performs a check whether a quota request is reasonable and can be satisfied > at the moment. A precise answer is impossible here, but a sanity check is > still helpful, because it allows us to filter knowingly unsatisfiable > requests. > > > Diffs > ----- > > src/master/master.hpp 3aa7017287506938d77bbfb1e06f510101009ee3 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38110/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >