> On Nov. 4, 2015, 2:44 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 151 > > <https://reviews.apache.org/r/38110/diff/10/?file=1114101#file1114101line151> > > > > So for this TODO, in future, we want to count dynamically reserved > > resources in ```roleTotal```, right? But in the code below, I see the > > dynamically reserved resources have already been counted in > > ```availableOnAgent```, so if we count it here as well, will it be double > > counted?
You're right, there is a danger that we end up doing double accounting after we add dynamic reservations. I'll add a todo to avoid that. Thanks! - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review105062 ----------------------------------------------------------- On Nov. 10, 2015, 10:52 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38110/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 10:52 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3074 > https://issues.apache.org/jira/browse/MESOS-3074 > > > Repository: mesos > > > Description > ------- > > Performs a check whether a quota request is reasonable and can be satisfied > at the moment. A precise answer is impossible here, but a sanity check is > still helpful, because it allows us to filter knowingly unsatisfiable > requests. > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38110/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
