> On Nov. 3, 2015, 5:52 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, lines 159-186 > > <https://reviews.apache.org/r/38110/diff/10/?file=1114101#file1114101line159> > > > > How to handle the following cases? Say two roles request quota: r1 and > > r2. > > > > When r1 request quota as 5, the availableInCluster is 10 and r1 set > > quota succeed. > > > > When r2 request quota as 7 again, the availableInCluster is still 10 as > > no one used resources in the cluster, so r2 set quota also succeed. > > > > But now the quota for r1 and r2 is 12 which exceeds 10, is this a valid > > case? Thanks. > > Alexander Rukletsov wrote: > This is a sanity check, the precise bookkeeping and quota allocation is > done by an allocator module. > > Guangya Liu wrote: > OK, got it. So we have two levels check, one is sanity check here and the > other is precise bookkeeping in allocator. The first sanity check can get > some early exception if there are not enough resources.
Exactly :-) - Joris ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review104875 ----------------------------------------------------------- On Nov. 10, 2015, 7:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38110/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 7:02 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3074 > https://issues.apache.org/jira/browse/MESOS-3074 > > > Repository: mesos > > > Description > ------- > > Performs a check whether a quota request is reasonable and can be satisfied > at the moment. A precise answer is impossible here, but a sanity check is > still helpful, because it allows us to filter knowingly unsatisfiable > requests. > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38110/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
