----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38110/#review106670 -----------------------------------------------------------
src/master/master.hpp (line 880) <https://reviews.apache.org/r/38110/#comment165407> s/reasonabily/reasonably? src/master/master.hpp (line 883) <https://reviews.apache.org/r/38110/#comment165408> As the force flag isn't there, whould we add a todo? Otherwise this comment is misleading. src/master/master.hpp (line 886) <https://reviews.apache.org/r/38110/#comment165409> This heuristic can still prevent frameworks without quota to receive offers in contrast to the above goal... src/master/quota_handler.cpp (line 117) <https://reviews.apache.org/r/38110/#comment165410> Is non-static cluster resources a fixed term? src/master/quota_handler.cpp (line 149) <https://reviews.apache.org/r/38110/#comment165412> this sounds like as if the force flag is a solution to this. How about consider: If you want to override this check, consider using the force attribute. - Joerg Schad On Nov. 16, 2015, 10:27 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38110/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 10:27 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3074 > https://issues.apache.org/jira/browse/MESOS-3074 > > > Repository: mesos > > > Description > ------- > > The heuristic tests whether the total quota, including the new request, does > not exceed the sum of non-static cluster resources. The goal of this checkis > to determine whether a user may accidentally request an amount of resources > that would prevent frameworks without quota from getting any offers. A force > flag will be introduced in the future and will allow users to bypass this > check. > > > Diffs > ----- > > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38110/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
