----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40403/#review107074 -----------------------------------------------------------
Ship it! src/uri/schemes/http.hpp (line 38) <https://reviews.apache.org/r/40403/#comment166001> consider merging `uri/schemes/*` and `src/uri/utils.cpp` into a single `src/uri.cpp` file. - Vinod Kone On Nov. 17, 2015, 9:27 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40403/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 9:27 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added streaming and construction methods for URI. > > > Diffs > ----- > > include/mesos/uri/uri.hpp PRE-CREATION > src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/tests/uri_tests.cpp PRE-CREATION > src/uri/schemes/file.hpp PRE-CREATION > src/uri/schemes/http.hpp PRE-CREATION > src/uri/utils.hpp PRE-CREATION > src/uri/utils.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40403/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >