----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38956/#review107306 -----------------------------------------------------------
src/tests/master_quota_tests.cpp (line 222) <https://reviews.apache.org/r/38956/#comment166361> Shouldn't the expect call happen before StartSlave()? Otherwise the slave might have started before and we will never satisfy the call... src/tests/master_quota_tests.cpp (line 270) <https://reviews.apache.org/r/38956/#comment166364> move before StartSlave() src/tests/master_quota_tests.cpp (line 282) <https://reviews.apache.org/r/38956/#comment166365> Move before StartSlave() src/tests/master_quota_tests.cpp (line 332) <https://reviews.apache.org/r/38956/#comment166366> Move before StartSlave() src/tests/master_quota_tests.cpp (line 383) <https://reviews.apache.org/r/38956/#comment166359> Shouldn't we have the expect call before StartSlave()? Otherwise this is a potential race condition which might lead to the ExpectCall never fullfilled (as the slave already started before we started expecting it). src/tests/master_quota_tests.cpp (line 395) <https://reviews.apache.org/r/38956/#comment166360> Same here. - Joerg Schad On Nov. 17, 2015, 8:16 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38956/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 8:16 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Michael Park. > > > Bugs: MESOS-3720 > https://issues.apache.org/jira/browse/MESOS-3720 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/38956/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
