----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review107527 -----------------------------------------------------------
src/slave/slave.cpp (line 4417) <https://reviews.apache.org/r/40379/#comment166739> s/oversubscribable/USAGE_SLACK oversubscribable src/slave/slave.cpp (line 4419) <https://reviews.apache.org/r/40379/#comment166740> I think that the oversubscribable resources should always has_revocable()? For which case does the oversubscribable resource do not has_revocable()? Caused by a bad resource estimitator? For such case, can we let slave throw exception? - Guangya Liu On 十一月 21, 2015, 11:26 a.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40379/ > ----------------------------------------------------------- > > (Updated 十一月 21, 2015, 11:26 a.m.) > > > Review request for mesos and Guangya Liu. > > > Bugs: MESOS-3930 > https://issues.apache.org/jira/browse/MESOS-3930 > > > Repository: mesos > > > Description > ------- > > In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK > for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps > to update `RevocableInfo::type` for Oversubscription. > > > Diffs > ----- > > src/slave/resource_estimators/fixed.cpp 305664c > src/slave/slave.cpp d1126f0 > src/tests/oversubscription_tests.cpp 0d0bf7e > > Diff: https://reviews.apache.org/r/40379/diff/ > > > Testing > ------- > > make (make check is on-going) > > > Thanks, > > Klaus Ma > >
