----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108032 -----------------------------------------------------------
Patch looks great! Reviews applied: [39590, 39591, 39592, 40445] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 25, 2015, 9:59 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40445/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 9:59 a.m.) > > > Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park. > > > Bugs: MESOS-3581 > https://issues.apache.org/jira/browse/MESOS-3581 > > > Repository: mesos > > > Description > ------- > > Added linter for license headers in some file types. > > > Diffs > ----- > > support/mesos-license.py PRE-CREATION > support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 > > Diff: https://reviews.apache.org/r/40445/diff/ > > > Testing > ------- > > Ran the a whole clean checkout through the linter with only one expected > failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a > license). > > > NOTE TO THE COMMITTER > --------------------- > > Before committing this, it is probably a good idea to check the whole code > base again and fix any new files which do not follow the current license > style. The commits which originally fixed this were > > * fa36917 (mesos), > * dc23756 (stout), and > * 3539b7a (libprocess). > > > Thanks, > > Benjamin Bannier > >