----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40445/#review108745 -----------------------------------------------------------
support/mesos-style.py (line 5) <https://reviews.apache.org/r/40445/#comment168204> Why the introduction of the `print` function? Can't we just use `print` and `.format`? support/mesos-style.py (lines 63 - 64) <https://reviews.apache.org/r/40445/#comment168205> Is this meant to be commented out? support/mesos-style.py (lines 74 - 75) <https://reviews.apache.org/r/40445/#comment168206> Why the change here? support/mesos-style.py (line 91) <https://reviews.apache.org/r/40445/#comment168207> Do we allow arbitrary whitespace `\s`? or do we want to lock it down to exactly one space character? - Michael Park On Dec. 2, 2015, 11:18 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40445/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 11:18 a.m.) > > > Review request for mesos, Benjamin Hindman, Marco Massenzio, and Michael Park. > > > Bugs: MESOS-3581 > https://issues.apache.org/jira/browse/MESOS-3581 > > > Repository: mesos > > > Description > ------- > > Added linter for license headers in some file types. > > > Diffs > ----- > > support/mesos-style.py 66b45692c3c04f68358b63d52e4d87934f241bd7 > > Diff: https://reviews.apache.org/r/40445/diff/ > > > Testing > ------- > > Ran the a whole clean checkout through the linter with only one expected > failure (`3rdparty/libprocess/stout/tests/protobuf_tests.proto` which lacks a > license). > > > NOTE TO THE COMMITTER > --------------------- > > Before committing this, it is probably a good idea to check the whole code > base again and fix any new files which do not follow the current license > style. The commits which originally fixed this were > > * fa36917 (mesos), > * dc23756 (stout), and > * 3539b7a (libprocess). > > > Thanks, > > Benjamin Bannier > >