----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40529/#review108433 -----------------------------------------------------------
include/mesos/resources.hpp (lines 155 - 156) <https://reviews.apache.org/r/40529/#comment167893> Can you add a comment here to explain that this is the same as `!isPersistentVolume`? i.e. This function is not redundant. There is only one type of stateful resource currently. But if more are added in future, this function should be extended accordingly. --- Note: You may want to hold back on copy-pasting the comment all over this patch (which we will eventually want). We will likely iterate over the wording a bit first :) - Joseph Wu On Nov. 24, 2015, 11:31 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40529/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 11:31 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, > and Klaus Ma. > > > Bugs: MESOS-3955 > https://issues.apache.org/jira/browse/MESOS-3955 > > > Repository: mesos > > > Description > ------- > > Added helper function to get stateless resources. > > > Diffs > ----- > > include/mesos/resources.hpp 51c63f8305f6c0313e0b34f912f5e53396a1591d > include/mesos/v1/resources.hpp b481a9e0177b5253acc2585d5dfc6228ab63876c > src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c > src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 > src/v1/resources.cpp 8488c318a987a150fc5fde26b54246e8effb0428 > > Diff: https://reviews.apache.org/r/40529/diff/ > > > Testing > ------- > > > Thanks, > > Guangya Liu > >
