----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review108496 -----------------------------------------------------------
src/master/master.hpp (line 706) <https://reviews.apache.org/r/39987/#comment167947> If the intention is to be similar to the `authorizeTask` interface, we should take `Resources` here instead? Although I think taking `Offer::Operation::Reserve` would be best here. src/master/master.hpp (line 730) <https://reviews.apache.org/r/39987/#comment167948> Similar question as above. src/master/master.cpp (line 2771) <https://reviews.apache.org/r/39987/#comment167950> Why is it that we need to perform validation within authorization? We perform `authorizeTask` with a `TaskInfo` that has not been validated yet, and take care of it later on. Does that pattern not work here? - Michael Park On Nov. 30, 2015, 8:35 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39987/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 8:35 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff. > > > Bugs: MESOS-3062 > https://issues.apache.org/jira/browse/MESOS-3062 > > > Repository: mesos > > > Description > ------- > > Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve. > Note: this review is continued from https://reviews.apache.org/r/37125/ > > > Diffs > ----- > > src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe > src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 > > Diff: https://reviews.apache.org/r/39987/diff/ > > > Testing > ------- > > This is the third in a chain of 5 patches. `make check` was used to test > after all patches were applied. > > > Thanks, > > Greg Mann > >
