> On Dec. 2, 2015, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 2775 > > <https://reviews.apache.org/r/39987/diff/10/?file=1150202#file1150202line2775> > > > > I believe you inherited the TODO from MPark. Do you want to preserve > > his name or change to yours?
I was going to leave his name, since he's the original author of the TODO :-) > On Dec. 2, 2015, 2:17 p.m., Alexander Rukletsov wrote: > > src/master/master.cpp, line 2781 > > <https://reviews.apache.org/r/39987/diff/10/?file=1150202#file1150202line2781> > > > > Maybe "' to reserve any resources"? Or mention what resources are > > allowed to reserve (similar to what you do in `authorizeUnreserveResources`. Good call! Changed. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review108638 ----------------------------------------------------------- On Dec. 2, 2015, 6 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39987/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 6 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff. > > > Bugs: MESOS-3062 > https://issues.apache.org/jira/browse/MESOS-3062 > > > Repository: mesos > > > Description > ------- > > Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve. > Note: this review is continued from https://reviews.apache.org/r/37125/ > > > Diffs > ----- > > src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe > src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 > > Diff: https://reviews.apache.org/r/39987/diff/ > > > Testing > ------- > > This is the third in a chain of 5 patches. `make check` was used to test > after all patches were applied. > > > Thanks, > > Greg Mann > >
