----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39987/#review108655 -----------------------------------------------------------
src/master/master.cpp (lines 2769 - 2770) <https://reviews.apache.org/r/39987/#comment168116> Is my understanding is correct, we do not allow reserving resources neither for operators nor for frameworks without a principal. Why do we have a path for `ACL::Entity::Any` here then? If you plan to reserve it for future use cases or just be more general — it's fine, but let's leave a fat comment that this is not possible currently (or how it's possible if my understanding is not correct). A follow-up question: Is it something we have agreed and maybe even documented somewhere, that certain actions require principal? I'm thinking about authz for quota and whether we have to make `principal` required there. - Alexander Rukletsov On Dec. 2, 2015, 9 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39987/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 9 a.m.) > > > Review request for mesos, Adam B, Jie Yu, Michael Park, and Till Toenshoff. > > > Bugs: MESOS-3062 > https://issues.apache.org/jira/browse/MESOS-3062 > > > Repository: mesos > > > Description > ------- > > Added 'Master::authorize(Un)reserveResources()' for Reserve/Unreserve. > Note: this review is continued from https://reviews.apache.org/r/37125/ > > > Diffs > ----- > > src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe > src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821 > > Diff: https://reviews.apache.org/r/39987/diff/ > > > Testing > ------- > > This is the third in a chain of 5 patches. `make check` was used to test > after all patches were applied. > > > Thanks, > > Greg Mann > >