----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40988/#review109033 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Dec. 4, 2015, 9:50 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40988/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2015, 9:50 p.m.) > > > Review request for mesos, Jie Yu and Cong Wang. > > > Repository: mesos > > > Description > ------- > > stout: Fixed comments for numify(), cleaned up some test code. > > Note that numify() handles negative numbers inconsistently, depending on > whether they are specified in hex or decimal (see test case). Can you guys > take a look at fixing? > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/numify.hpp > 322a89946befb0d7006124a08b415e2ef0a03e97 > 3rdparty/libprocess/3rdparty/stout/tests/numify_tests.cpp > 522fc3470eb3496f7dfe1eeb814b171bcff21f38 > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > fc5a821bf3bb1416b67103d0ffd7ab5b88f45cca > 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp > 7fa06a980b58040f68bf92d217c866f9e48a57d3 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > 7c0309c41ee5ad18bed30aa31a8361f11bca23a1 > > Diff: https://reviews.apache.org/r/40988/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >
