> On Dec. 4, 2015, 1:15 p.m., Niklas Nielsen wrote: > > Hi Haosdent! > > > > I apologize the tardy reply. The patch looks good but needs rebasing. > > Also, have you thought of a way to test this? > > > > With a test (maybe by just ensuring the existing ordering of the test > > modules are indeed run in order), we should be able to land this. Kapil, > > any concerns on this? > > Guangya Liu wrote: > @nnielsen, does this test help? Thanks! > https://github.com/apache/mesos/blob/master/3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp#L93-L106
That should be fine - rebase and let's get it in. (Kapil, any objections?) - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40056/#review109028 ----------------------------------------------------------- On Nov. 8, 2015, 4:58 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40056/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2015, 4:58 a.m.) > > > Review request for mesos, Ben Mahler, Kapil Arya, and Niklas Nielsen. > > > Bugs: MESOS-3485 > https://issues.apache.org/jira/browse/MESOS-3485 > > > Repository: mesos > > > Description > ------- > > Make hook execution order deterministic. > > > Diffs > ----- > > src/hook/manager.cpp d9e660a3b6f6d13d9f6b59f53bfc8a4f65af6df4 > > Diff: https://reviews.apache.org/r/40056/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
