----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review109684 -----------------------------------------------------------
1. We badly need a unit test for this. :-) 2. If I understand correctly, the reason you did not use the automated protobuf to JSON converters and had to use `model(...)` is that `labels` is populated in a custom way in the `state.json` endpoint and you wanted to preserve that ? src/common/http.hpp (line 84) <https://reviews.apache.org/r/41188/#comment169289> Based on my comment in an earlier review , do we need this ? src/common/http.cpp (line 158) <https://reviews.apache.org/r/41188/#comment169290> Missing period at the end. src/common/http.cpp (line 159) <https://reviews.apache.org/r/41188/#comment169291> Do we need this ? src/common/http.cpp (line 195) <https://reviews.apache.org/r/41188/#comment169292> Missing period at the end. src/slave/http.cpp (line 96) <https://reviews.apache.org/r/41188/#comment169293> Missing Period - Anand Mazumdar On Dec. 10, 2015, 3:36 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41188/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 3:36 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Providing JSON bindings to so that mesos modules can expose DiscoveryInfo > protobuf messages to HTTP endpoints > > > Diffs > ----- > > src/common/http.hpp 6a7a14ce8f1b9e0a85bc88bcf32bd80ea56bb7be > src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 > src/slave/http.cpp cef568d77da430b96e8f97487a8d0406dc0a0116 > > Diff: https://reviews.apache.org/r/41188/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
