> On Dec. 10, 2015, 4:52 a.m., Anand Mazumdar wrote: > > 1. We badly need a unit test for this. :-) > > 2. If I understand correctly, the reason you did not use the automated > > protobuf to JSON converters and had to use `model(...)` is that `labels` is > > populated in a custom way in the `state.json` endpoint and you wanted to > > preserve that ?
Added a unit-test case for testing DiscoveryInfo injection in state.json for slave and modeling of DiscoveryInfo as a JSON object in master. Also using the generic JSON::protobuf API to convert protobuf to JSON. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41188/#review109684 ----------------------------------------------------------- On Dec. 12, 2015, 7:37 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41188/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 7:37 a.m.) > > > Review request for mesos and Adam B. > > > Bugs: MESOS-3962 > https://issues.apache.org/jira/browse/MESOS-3962 > > > Repository: mesos > > > Description > ------- > > Providing JSON bindings to so that mesos modules can expose DiscoveryInfo > protobuf messages to HTTP endpoints > > > Diffs > ----- > > src/slave/http.cpp d1b1158c0a80d72c32c9b28977043b6be2295239 > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41188/diff/ > > > Testing > ------- > > make check. > Added Unit tests to verify setting of DiscoveryInfo in state.json in slave. > Also added Unit test to test that DiscoveryInfo gets exposed in master when > TaskInfo protobuf is converted to JSON objects. > > > Thanks, > > Avinash sridharan > >
