----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40379/#review110014 -----------------------------------------------------------
include/mesos/slave/resource_estimator.hpp (lines 61 - 63) <https://reviews.apache.org/r/40379/#comment169764> Suggestion: NOTE: For backwards compatibility, the agent will set the `type` of `RevocableInfo` for these resources to `USAGE_SLACK`. This is the only type of revocable resources handled by the estimator. src/slave/slave.cpp (line 4461) <https://reviews.apache.org/r/40379/#comment169765> s/overwrote/overwritten/ - Joseph Wu On Dec. 3, 2015, 9:17 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40379/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 9:17 p.m.) > > > Review request for mesos, Guangya Liu, Artem Harutyunyan, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3930 > https://issues.apache.org/jira/browse/MESOS-3930 > > > Repository: mesos > > > Description > ------- > > In Optimistic Offer Phase 1, it introduce `RevocableInfo::type`: USAGE_SLACK > for Oversubscription and ALLOCATION_SLACK for Optimistic Offer. Slave helps > to update `RevocableInfo::type` for Oversubscription. > > > Diffs > ----- > > include/mesos/slave/resource_estimator.hpp 27612ca > src/slave/slave.cpp 777f36b > > Diff: https://reviews.apache.org/r/40379/diff/ > > > Testing > ------- > > make (make check is on-going) > > > Thanks, > > Klaus Ma > >
