----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40347/#review110048 -----------------------------------------------------------
Hey Jan, would you mind rebasing this chain? I just got a "patch does not apply" when applying this third one. I was hoping to compile and exercise the tests :-) Also, I noticed that the tests are associated with a different JIRA and haven't been added to the 'mesos' group on here yet... I understand the desire to keep things moving, but it would be nice to verify this new authorization functionality with passing tests before merging. I can have a look at the tests and help review those as well. - Greg Mann On Dec. 7, 2015, 2:34 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40347/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 2:34 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Joris Van > Remoortere, and Till Toenshoff. > > > Bugs: MESOS-3862 > https://issues.apache.org/jira/browse/MESOS-3862 > > > Repository: mesos > > > Description > ------- > > Quota: Implemented quota request authorization. > > > Diffs > ----- > > src/master/master.hpp 4683fa542a740f9a0b80fff7fbe0e63ec66266f2 > src/master/quota_handler.cpp b209da42ace752953686eeda9577007a33556d5d > > Diff: https://reviews.apache.org/r/40347/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
