> On Dec. 10, 2015, 2:48 a.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp, line 21 > > <https://reviews.apache.org/r/39583/diff/4/?file=1125978#file1125978line21> > > > > Maybe we can drop the `Try` specific part of this comment.
This comment is copied from the Unix version, and it does appear to be true. So I recommend we keep it. But, if we want to change it, we should actually change it in both places. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review109665 ----------------------------------------------------------- On Dec. 10, 2015, 2:14 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39583/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 2:14 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-4110 > https://issues.apache.org/jira/browse/MESOS-4110 > > > Repository: mesos > > > Description > ------- > > Windows: Added `WindowsError` to parallel `ErrnoError`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > a8c35c086ecae21701f6a720f25231c1b0d4e329 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > fdd33512c8d8752093f72f597a7d647eb5e3c285 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39583/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
