----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39583/#review109665 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp (lines 27 - 29) <https://reviews.apache.org/r/39583/#comment169255> Let's move this into `<stout/error.hpp>` 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 1 - 13) <https://reviews.apache.org/r/39583/#comment169256> new license header format. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 21) <https://reviews.apache.org/r/39583/#comment169257> Maybe we can drop the `Try` specific part of this comment. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 43) <https://reviews.apache.org/r/39583/#comment169261> Full words if not part of the API. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 47) <https://reviews.apache.org/r/39583/#comment169260> new line. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 61 - 63) <https://reviews.apache.org/r/39583/#comment169262> let's clarify this as per offline discussion. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 77) <https://reviews.apache.org/r/39583/#comment169264> You can drop the "as far as I can tell" 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (lines 82 - 88) <https://reviews.apache.org/r/39583/#comment169266> indentation. 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp (line 86) <https://reviews.apache.org/r/39583/#comment169267> I think we put a space between the old c-style cast and the value. Can you check this? - Joris Van Remoortere On Dec. 10, 2015, 2:14 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39583/ > ----------------------------------------------------------- > > (Updated Dec. 10, 2015, 2:14 a.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Bugs: MESOS-4110 > https://issues.apache.org/jira/browse/MESOS-4110 > > > Repository: mesos > > > Description > ------- > > Windows: Added `WindowsError` to parallel `ErrnoError`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > a8c35c086ecae21701f6a720f25231c1b0d4e329 > 3rdparty/libprocess/3rdparty/stout/include/stout/try.hpp > fdd33512c8d8752093f72f597a7d647eb5e3c285 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/error.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/39583/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
