----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review110308 -----------------------------------------------------------
src/slave/main.cpp (lines 227 - 245) <https://reviews.apache.org/r/41167/#comment170129> I am wondering why logger has to be injected, instead of being owned by containerizer? Let containerizer owning the logger can simplify the implementation (especially the tests) a lot. Also, logically speaking, logger should be part of the containerizer, not the agent. - Jie Yu On Dec. 12, 2015, 12:39 a.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41167/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2015, 12:39 a.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4088 > https://issues.apache.org/jira/browse/MESOS-4088 > > > Repository: mesos > > > Description > ------- > > Changes the agent executables to create and initialize the `ContainerLogger`. > The `MesosContainerizer` modifies the arguments to `launcher->fork()` by > calling the `ContainerLogger` beforehand. > > > Diffs > ----- > > src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f > src/slave/containerizer/mesos/containerizer.cpp > 6dad2e858b68cf47e048d49d34af4fa4cb3b6841 > src/slave/main.cpp 9d48a0823189ea6505073a2803f02d90dc382ab4 > > Diff: https://reviews.apache.org/r/41167/diff/ > > > Testing > ------- > > make > > This is tested later in the review chain. > > > Thanks, > > Joseph Wu > >
