> On Dec. 14, 2015, 1:21 p.m., Jie Yu wrote: > > src/slave/main.cpp, lines 227-245 > > <https://reviews.apache.org/r/41167/diff/2/?file=1161083#file1161083line227> > > > > I am wondering why logger has to be injected, instead of being owned by > > containerizer? Let containerizer owning the logger can simplify the > > implementation (especially the tests) a lot. > > > > Also, logically speaking, logger should be part of the containerizer, > > not the agent.
Migrated the `ContainerLogger` into the `MesosContainerizer`. I also tweaked some comments in the interface (way back at the beginning of this review chain). - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41167/#review110308 ----------------------------------------------------------- On Dec. 14, 2015, 3:47 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41167/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 3:47 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4088 > https://issues.apache.org/jira/browse/MESOS-4088 > > > Repository: mesos > > > Description > ------- > > Changes the `MesosContainerizer` to create and initialize the > `ContainerLogger`. > > The `MesosContainerizer` modifies the arguments to `launcher->fork()` (in > `::_launch`) by calling the `ContainerLogger` beforehand. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > ab87cbcc843b471c7931aa38a590896f97be9865 > src/slave/containerizer/mesos/containerizer.cpp > 6dad2e858b68cf47e048d49d34af4fa4cb3b6841 > > Diff: https://reviews.apache.org/r/41167/diff/ > > > Testing > ------- > > make > > This is tested later in the review chain. > > > Thanks, > > Joseph Wu > >
