----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110536 -----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 37) <https://reviews.apache.org/r/39888/#comment170464> Returning NULL without setting errno is probably not a good idea. We might want to standardize on '0' for group/user IDs on Windows. - Alex Naparu On Nov. 16, 2015, 9:15 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39888/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 9:15 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This code will be particularly useful when we expand Windows support for > `files/files.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > a8c35c086ecae21701f6a720f25231c1b0d4e329 > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/39888/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >