> On Dec. 9, 2015, 5:59 p.m., Alex Clemmer wrote: > > src/slave/cmake/SlaveConfigure.cmake, line 62 > > <https://reviews.apache.org/r/41108/diff/1/?file=1156611#file1156611line62> > > > > Same comment about the include directories, but with libraries. We > > probably want to include `CURL_LIBS` here.
So I wanted to verify the CURL_LIBS label that was being built in FindCurl before adding it to AGENT_LIB_DIRS. Here is the debug message output of a build: AGENT_LIB_DIRS = /root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/http_parser-1c3624a/src/http_parser-1c3624a-build;/root/mesos/build/3rdparty/libprocess/3rdparty/libev-4.15/src/libev-4.15-build/.libs;/root/mesos/build/3rdparty/libprocess/3rdparty/protobuf-2.5.0/src/protobuf-2.5.0-lib/lib/lib;/root/mesos/build/3rdparty/libprocess/3rdparty/glog-0.3.3/src/glog-0.3.3-lib/lib/lib;/root/mesos/build/3rdparty/zookeeper-3.4.5/src/zookeeper-3.4.5-lib/lib/lib CURL_LIBS = /usr/lib/x86_64-linux-gnu/libcurl.so CURL_LIB = /usr/lib/x86_64-linux-gnu/libcurl.so There is no lib directory field built in FindCurl. I can add this but note that this would differ from the FindApr and FindSvn scripts. Please advise. - Diana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41108/#review109566 ----------------------------------------------------------- On Dec. 8, 2015, 11:09 p.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41108/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2015, 11:09 p.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Add curl, sasl and dl link flags and add protobuf library directory > > > Diffs > ----- > > src/slave/cmake/SlaveConfigure.cmake > fbdfdaa27fbd8c7429861eea5baf401a221f748b > > Diff: https://reviews.apache.org/r/41108/diff/ > > > Testing > ------- > > Tested on Ubuntu and OSX. > > > Thanks, > > Diana Arroyo > >
