> On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > >
Thanks for the reviews, AlexR!! > On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, line 106 > > <https://reviews.apache.org/r/40167/diff/4/?file=1156029#file1156029line106> > > > > created the volume? :facepalm: Thanks AlexR :-) > On Dec. 16, 2015, 2:35 p.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto, lines 100-101 > > <https://reviews.apache.org/r/40167/diff/4/?file=1156029#file1156029line100> > > > > Why did you wrap the comment this way? This comment is just over 80 characters long, and by wrapping this way I reduce the overall "jaggedness". I find this a bit easier to read than a two-line comment that has just one or two words on the second line. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40167/#review110641 ----------------------------------------------------------- On Dec. 17, 2015, 12:03 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40167/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 12:03 a.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-4178 > https://issues.apache.org/jira/browse/MESOS-4178 > > > Repository: mesos > > > Description > ------- > > Added ACL protobuf messages 'CreateVolume' and 'DestroyVolume'. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.proto > 74fcc86d3c92cb3aa27e45b647b1653705b3201c > > Diff: https://reviews.apache.org/r/40167/diff/ > > > Testing > ------- > > This is the second in a chain of 7 patches. `make check` was used to test > after all patches were applied. > > Note that this chain of patches touches many of the same files as another > chain beginning with Review #39985 and ending with Review #39989, which is > currently in review as well. To avoid conflicts, the beginning of this chain > begins on top of Review #39989. > > > Thanks, > > Greg Mann > >
