----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41381/#review111362 -----------------------------------------------------------
src/tests/common/http_tests.cpp (line 101) <https://reviews.apache.org/r/41381/#comment171524> Since Task instances are exported through state endpoints on both the slave and the master you might as well query those to actually verify that DiscoverInfo is always available to consumers. See, please https://github.com/apache/mesos/blob/master/src/tests/health_check_tests.cpp#L254-L278 for an example. src/tests/slave_tests.cpp (lines 2242 - 2246) <https://reviews.apache.org/r/41381/#comment171522> How about using EXPECT_SOME_EQ here? src/tests/slave_tests.cpp (lines 2253 - 2257) <https://reviews.apache.org/r/41381/#comment171523> Ditto as above. But please submit a follow up patch if you decide to switch these (and possible other) occurences as well. - Artem Harutyunyan On Dec. 17, 2015, 3:15 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41381/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 3:15 p.m.) > > > Review request for mesos, Adam B and Anand Mazumdar. > > > Repository: mesos > > > Description > ------- > > Added unit test cases to test the new vip and instance_port fields > > > Diffs > ----- > > src/tests/common/http_tests.cpp 3aca5b0437a012664f58ff331cc7cf682d442699 > src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 > > Diff: https://reviews.apache.org/r/41381/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Avinash sridharan > >
