----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review112309 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 1302) <https://reviews.apache.org/r/40632/#comment172746> If framework has reserved.statless resources, allocator should not dispatch it as ALLOCATION_SLACK. src/master/allocator/mesos/hierarchical.cpp (line 1321) <https://reviews.apache.org/r/40632/#comment172745> As framework can not use ALLOCATION_SLACK mixed with other resources, allocator need to check seperatly. src/master/allocator/mesos/hierarchical.cpp (line 1334) <https://reviews.apache.org/r/40632/#comment172747> In this check, it seems allocator send offer when both !allocation & allocation are enough. - Klaus Ma On Dec. 30, 2015, 3:04 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2015, 3:04 p.m.) > > > Review request for mesos, Klaus Ma and Jian Qiu. > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >