> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1321 > > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1321> > > > > As framework can not use ALLOCATION_SLACK mixed with other resources, > > allocator need to check seperatly.
Yes, currently the validation logic in master is https://github.com/apache/mesos/blob/master/src/master/validation.cpp#L479-L488 which can make sure a task and its executor can either use non-revocable resources or revocable resources of a given name but not both. After we introduced the allocation slack, we may want to guard that a task and its executor can either use allocation slack or usage slack or non-revocable resources but not all. I will upload a patch to handle this part. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review112309 ----------------------------------------------------------- On 十二月 30, 2015, 7:04 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated 十二月 30, 2015, 7:04 a.m.) > > > Review request for mesos, Klaus Ma and Jian Qiu. > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f900c4e024485704d79e57ae22407557598fe6c > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
