> On Jan. 4, 2016, 10:33 p.m., Daniel Pravat wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp, line > > 94 > > <https://reviews.apache.org/r/39584/diff/9/?file=1180823#file1180823line94> > > > > Can you use _rmdir() instead to avoid another deprecation warning ?
Just a brief comment here: in windows.hpp there are aliases mapping POSIX functions to their underscore versions (_e.g._, `open` -> `_open`), but this is for compatibility in files where POSIX and Windows implementations are the same, so that we don't have to fork the implementation just because the names are slightly different. BUT, now that you point it out, I totally agree that we should call the actual function `_rmdir` instead when the file is Windows-specific. - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39584/#review112667 ----------------------------------------------------------- On Jan. 4, 2016, 11:26 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39584/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 11:26 p.m.) > > > Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph > Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Implemented `os::rmdir.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp > 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/rmdir.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/rmdir.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > 3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp > e738cdbf5846950c475c159fb9a770acc45159f5 > > Diff: https://reviews.apache.org/r/39584/diff/ > > > Testing > ------- > > `make check` from autotools on Ubuntu 15. > `make check` from CMake on OS X 10.10. > Ran `check` project in VS on Windows 10. > > > Thanks, > > Alex Clemmer > >
